Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Dinky-Admin] Some fields of type LocalDateTime lack Json serialization and deserialization annotations #3713

Closed
2 of 3 tasks
hekaiii opened this issue Aug 15, 2024 · 0 comments · Fixed by #3716
Closed
2 of 3 tasks
Labels
Bug Something isn't working Waiting for reply Waiting for reply

Comments

@hekaiii
Copy link

hekaiii commented Aug 15, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

org.dinky.data.model.rbac.Tenant#createTime
org.dinky.data.model.rbac.Tenant#updateTime
These two classes lack the @JsonDeserialize and @JsonSerialize annotations, which results in an error when different versions of jackson-datatype-jsr310 are introduced.
Error content:
Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type java.time.LocalDateTime not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through reference chain: org.dinky.data.result.Result["data"]->org.dinky.data.dto.UserDTO["tenantList"]->java.util.LinkedList[0]->org.dinky.data.model.rbac.Tenant["createTime"])
at com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:77) ~[jackson-databind-2.14.1.jar:2.14.1]

What you expected to happen

Fix this issue and check if other classes are missing the specified serialization-related annotations

How to reproduce

Add @JsonDeserialize and @JsonSerialize annotations

Anything else

No response

Version

1.0.1

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@hekaiii hekaiii added Bug Something isn't working Waiting for reply Waiting for reply labels Aug 15, 2024
@Zzm0809 Zzm0809 linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Waiting for reply Waiting for reply
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant