Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facts_to_tags, trusted_facts_to_tags, report_fact_tags and report_trusted_fact_tags could be one argument #665

Open
albertvaka opened this issue Oct 22, 2020 · 2 comments

Comments

@albertvaka
Copy link
Contributor

albertvaka commented Oct 22, 2020

There is no real distinction between facts_to_tags, trusted_facts_to_tags, report_fact_tags and report_trusted_fact_tags from the user point of view, but changing it would be a breaking change. Let's do this in the next major version bump.

Those fields were added in #658, #641 and #662

@mx-psi
Copy link
Member

mx-psi commented Oct 23, 2020

Is there no problem then with possible duplicate fact keys among those? e.g. having a fact and a trusted fact with the same name

@albertvaka
Copy link
Contributor Author

We could make them be in facts['trusted'] or something like this? Maybe that's less intuitive :/ At least, we could simplify this to two variables (facts/trusted facts) and not have a set of variables for tags that end up in the agent config and another one for tags that are used when calling the API directly (since that difference is an implementation detail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants