Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBERNETES_NAMESPACE_NAME_REGEX does not support '*' #242

Open
munnerz opened this issue Sep 19, 2017 · 1 comment
Open

KUBERNETES_NAMESPACE_NAME_REGEX does not support '*' #242

munnerz opened this issue Sep 19, 2017 · 1 comment

Comments

@munnerz
Copy link

munnerz commented Sep 19, 2017

Additional environment details (Operating System, Cloud provider, etc):
Kubernetes

Steps to reproduce the issue:

  1. Attempt to run docker-dd-agent with KUBERNETES_NAMESPACE_NAME_REGEX set to '.*'

Describe the results you received:

  • Observe /entrypoint.sh: 66: [: .: unexpected operator in logs
  • The namespace REGEX is not written to disk

Describe the results you expected:

  • dd-agent should watch all namespaces for Kubernetes events

Additional information you deem important (e.g. issue happens only occasionally):

This appears to happen as the entrypoint script does not quote values when checking if they are set (see: https://github.com/DataDog/docker-dd-agent/blob/master/entrypoint.sh#L58)

As a temporary workaround, I replaced .* with .+, which does solve the issue as + is not evaluated by the shell.

@cknowles
Copy link

Hit this as well but used a different workaround of double quoted single quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants