Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labstack/echo v3.3.10 dependency vulnerability #2762

Open
Lexdamian opened this issue Jun 27, 2024 · 4 comments
Open

labstack/echo v3.3.10 dependency vulnerability #2762

Lexdamian opened this issue Jun 27, 2024 · 4 comments
Labels
waiting-for-info waiting for answer from issue creator

Comments

@Lexdamian
Copy link

I suggest removal of labstack/echo v3.3.10 entirely and update the repo to use v4.11.1 instead

@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Jun 27, 2024
@darccio
Copy link
Contributor

darccio commented Jun 27, 2024

Hi @Lexdamian, thanks for the suggestion. This removal is planned in our v2 release, still in the works.

Is this causing you any issue that would require us to tackle it before our v2 release?

@Lexdamian
Copy link
Author

Lexdamian commented Jun 27, 2024

Hello! I am fixing vulnerabilities issues that are critical and this one is blocking a bunch of repos on our side. What's the release schedule for v2? I have a PR ready for the above mentioned remediation just in case.

@darccio
Copy link
Contributor

darccio commented Jun 27, 2024

@Lexdamian Unless you import our contrib for labstack/echo you aren't vulnerable. Please check our SECURITY.md:

If you are using a vulnerability checker other than golang.org/x/vuln/vulncheck you may detect vulnerabilities in our contrib dependencies. In general we like to specify non-vulnerable minimum versions of dependencies when we can do so in a non-breaking way. To avoid breaking users of this library there may be contrib libraries that are deprecated/vulnerable but still appear in our go.mod file. If you are not using these contrib packages you are not vulnerable (i.e. if they do not appear in your go.sum file). At the next major version we will drop support for these packages. (e.g. as of dd-trace-go@v1 labstack/echo v3 is considered deprecated and users should migrate to labstack/echo.v4)

Regarding v2, there isn't a release schedule yet.

@darccio darccio removed the needs-triage New issues that have not yet been triaged label Jul 1, 2024
@darccio
Copy link
Contributor

darccio commented Jul 3, 2024

@Lexdamian Can you confirm you are still affected according to vulncheck? As I already stated, unless you import explicitly the labstack/echo contrib, you shouldn't be affected by any vulnerability related to it.

@darccio darccio added the waiting-for-info waiting for answer from issue creator label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-info waiting for answer from issue creator
Projects
None yet
Development

No branches or pull requests

2 participants