Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress report 2 comments #1

Open
djvill opened this issue Nov 29, 2021 · 0 comments
Open

Progress report 2 comments #1

djvill opened this issue Nov 29, 2021 · 0 comments

Comments

@djvill
Copy link
Member

djvill commented Nov 29, 2021

You've done a lot of data processing---really nice work! I'm particularly impressed with how you've been able to leverage a lot of different skills in putting your data together

Please knit data_processing_note.Rmd so readers can read it as a more readable GitHub Markdown document

Remember not to set the working directory---use relative paths instead! Otherwise Jenny Bryan will "come into your office and SET YOUR COMPUTER ON FIRE" (https://twitter.com/hadleywickham/status/940021008764846080/photo/1)

Where does PELIC_speech_compiled.csv come from? Please make sure it's shared in your repo, because otherwise nobody else will be able to reconstruct your analysis!

I'm a little confused by new_wdDat and why there are just 3 files represented---is that just so you have a smaller sample to work with for testing?

You might want to use more descriptive object names; future-you might not remember what the difference between dat2 and dat3 was supposed to be! Note also that you've got two different objects named dat that don't appear to be the same thing. In general, if you find yourself struggling to come up with good names for an object, that might be a signal that it doesn't need to be its own object; you could probably pare down the number of dataframes you create

Re: the PrimaryStress coding, here's a simple to fix it: replace lines 150-152 with mutate(stress = if_else(str_detect(paste0("[", PrimaryStress, "]"), currentSyll), "stressed", "unstressed")). This turns PrimaryStress into a regex character class (paste0("[", PrimaryStress, "]") to surround PrimaryStress with square brackets) that currentSyll is matched against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant