New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Windows build fails due to non-standard C++ code #39

Open

andyburras opened this issue Dec 21, 2017 · 0 comments

andyburras commented Dec 21, 2017

In PostprocessData.cpp:

for (int j = i; list[j].offset < (offset + segmentSizes[index]); j++) {
...
}
errprint("[...]",index, list[j].offset);

Does not obey C++ standard rules - the scope of the name(s) declared extends to the end of the for statement.

In ValidateAtoms.cpp:

char vsdi_name[strlen(vsdi.name)];
and saio_offset ...

Using non-standard C++ dynamic array lengths - (this has been adopted by the C standard and is supported in g++, but it is not in the C++ standard).

In ValidateMP4.h:

true and false are #defined.

C++ Standard Library forbids macroizing keywords

Plus Visual Studio projects do not compile with latest (2017) VS version.

andyburras mentioned this issue

Fixes for Windows build failures, and stack overwrite - see #39 and #41 #40

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment