Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change component color #210

Open
Max2433BO opened this issue Dec 11, 2021 · 7 comments
Open

Change component color #210

Max2433BO opened this issue Dec 11, 2021 · 7 comments
Labels
enhancement A suggestion about how to improve the project

Comments

@Max2433BO
Copy link
Contributor

Hi @DarwinNE

I leave you this reminder of a request made by the user gianniniivo of electroyou.it:

It could be implemented, in the new version of FidoCadJ, the possibility of changing the color of the components as is currently possible for the other elements (lines, curves, letters, ...)?

Bye, Max

@DarwinNE DarwinNE added the enhancement A suggestion about how to improve the project label Apr 24, 2022
@JoopN
Copy link
Contributor

JoopN commented May 24, 2022

??? That is already possible. Mark a line, go to the bar with the drop down menu which is probably on "circuit", open it and choose a color. You can do this too with complex parts from the lib. Place the part in the workarea, de-vectorize the part and give a component of that part a different color in the same way as above. Of course its only for that particularly drawing in which you changes it. It won't work in an other drawing, that has to do with compatibility.

@DarwinNE
Copy link
Owner

I think the issue of the OP was that you have to split the components into primitives to change their layer. You loose the symbol. For the schematics, it would be nice to have symbols that somewhat inherit the layer without having to be split.
I have not implemented this as it is not trivial, I have to think about it so that to minimize the changes to the file format, for instance.

@JoopN
Copy link
Contributor

JoopN commented May 25, 2022

No, you don't loose the symbol, its still available in the lib. Only in your drawing its changed, all symbols with ability of colour can change this way, other components need to be de-vectorized and can change then from color. And its just only in your drawing, next drawing is again the standard.

@DarwinNE
Copy link
Owner

Of course you do not loose the symbol in the library. What I meant is that you have the coloured symbol that is not anymore a symbol (a macro in the FidoCadJ jargon). That means that if you try to move it, you have to move all the primitives.

I think this is the issue that @Max2433BO is talking about.

@JoopN
Copy link
Contributor

JoopN commented Jun 13, 2022

I want to show you what I have in my own lib up to now
example lib Joop 1_0 with color small

For me this is what I want with color, as an example, a led emits light, but the component is the same as all others with different light, so why make the body of the diode in a different color?

@DarwinNE
Copy link
Owner

It may make sense when, for a reason or another, you want to focus on a certain part of your circuit:

image

However, symbols contain their own elements and each one has its layer. Therefore, one should implement a technique to override it and this is not something I am planning to do, at least in a near future.

@JoopN
Copy link
Contributor

JoopN commented Jun 25, 2022

I know, you wrote something about it, I just want to show how I solved the problem for a part, however my Italian is absent so I don't know exactly what gianniniivo of electroyou.it wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion about how to improve the project
Projects
None yet
Development

No branches or pull requests

3 participants