Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcoming Webpack5 compatibility #50

Open
aaarichter opened this issue Nov 21, 2019 · 6 comments · May be fixed by #86
Open

Upcoming Webpack5 compatibility #50

aaarichter opened this issue Nov 21, 2019 · 6 comments · May be fixed by #86
Assignees
@DanielSchaffer
Labels
needs-investigation webpack v5

Comments

@aaarichter
Copy link

Hi @DanielSchaffer ,

with webpack5 at it's doorstep, I noticed that with webpack@next (v5.0.0-beta7) the following line

webpack-babel-multi-target-plugin/src/babel.target.multi.entry.plugin.ts

Line 4 in c7e8ddd

import MultiModuleFactory = require('webpack/lib/MultiModuleFactory')
throws:

⬢ webpack:  { Error: Cannot find module 'webpack/lib/MultiModuleFactory'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Function.Module._load (internal/modules/cjs/loader.js:507:25)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (node_modules/webpack-cli/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
    at Object.<anonymous> (node_modules/webpack-babel-multi-target-plugin/dist/src/babel.target.multi.entry.plugin.js:11:28)
    at Module._compile (node_modules/webpack-cli/node_modules/v8-compile-cache/v8-compile-cache.js:194:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3) code: 'MODULE_NOT_FOUND' }

It looks like v5 changed their /lib structure
@aaarichter aaarichter mentioned this issue Nov 25, 2019
Closed
@DanielSchaffer
Copy link
Owner

@aaarichter hey, thanks for letting me know. I'll have to poke around with v5 a bit.

@DanielSchaffer DanielSchaffer self-assigned this Nov 30, 2019
@shurygindv
Copy link

shurygindv commented Dec 4, 2019 •
edited
Loading

@DanielSchaffer, do you have plans to up-to-date (dev)dependencies to the latest?) or it may redundant now.. (package.json) 🙂

(sorry for an improper topic)

@DanielSchaffer
Copy link
Owner

@shurygindv I've sort of been avoiding it unless there's a security vulnerability, or something I need. You know, "if it ain't broke..." Is there anything in particular you're interested in?

@moderndeveloperllc
Copy link

@DanielSchaffer Not sure what packages @shurygindv was concerned about, but core-js 2.x is no longer developed. Can't imagine updating that would really affect much, but it would keep uf from seeing the deprecation warning every install!

@Austaras
Copy link
Contributor

So as webpack@5 has been released today, is there any plan for supporting it?

@DanielSchaffer
Copy link
Owner

@Austaras There is a "yes, I'd (ideally) like to do that" intention, but no specific or documented plan as of yet. I'm currently finishing up a milestone on another (personal) project right now, and I can put some energy towards supporting v5 once that's wrapped up. I'm also open to community submissions, of course :)

@Austaras Austaras linked a pull request Oct 20, 2020 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielSchaffer DanielSchaffer

Labels
needs-investigation webpack v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support webpack@5 Austaras/webpack-babel-multi-target-plugin
5 participants
@DanielSchaffer @moderndeveloperllc @aaarichter @Austaras @shurygindv