Newline errors during build

[knuxyl]

Ubuntu build

rgbasm -D _RED -h -o main_red.o main.asm
ERROR: main.asm(14) -> home.asm(12):
syntax error, unexpected newline
ERROR: main.asm(14) -> home.asm(805) -> home/audio.asm(194):
syntax error, unexpected newline
ERROR: main.asm(14) -> home.asm(805) -> home/audio.asm(219):
syntax error, unexpected identifier
ERROR: main.asm(490) -> scripts/PowerPlant.asm(10):
syntax error, unexpected newline
ERROR: main.asm(717) -> scripts/CeruleanCaveB1F.asm(10):
syntax error, unexpected newline
ERROR: main.asm(779) -> scripts/CeladonMart3F.asm(77):
syntax error, unexpected newline
error: Assembly aborted (6 errors)!

After fixing some of those complaints it seems as though the entire audio engine is messed up due to I guess porting crystal's over. I don't know if it's related too, when blacking out in a battle it goes to black screen and hangs, not sure if because of audio problems, most likely.

[TheR3dMage]

I got the same error in Ubuntu so I tried installing on Windows. The error appears in that version also:

$ make red

rgbasm -D _RED -h -o main_red.o main.asm
ERROR: main.asm(14) -> home.asm(12):
    syntax error, unexpected newline
ERROR: main.asm(14) -> home.asm(805) -> home/audio.asm(194):
    syntax error, unexpected newline
ERROR: main.asm(14) -> home.asm(805) -> home/audio.asm(219):
    syntax error, unexpected identifier
ERROR: main.asm(490) -> scripts/PowerPlant.asm(10):
    syntax error, unexpected newline
ERROR: main.asm(717) -> scripts/CeruleanCaveB1F.asm(10):
    syntax error, unexpected newline
ERROR: main.asm(779) -> scripts/CeladonMart3F.asm(77):
    syntax error, unexpected newline
error: Assembly aborted (6 errors)!
make: *** [Makefile:61: main_red.o] Error 1

Wish I had known that before taking the time to install cygwin :(

[vbaier]

I reached out to Dabomstew and he helped me out here. RGBDS has had some breaking changes since pokered-speedchoice was last built and you will need a version contemporary to this build for the rom to build successfully. I got things working with the v0.4.1 tag of RGBDS.

Once you have cloned RGBDS over, run git checkout v0.4.1. I then recommend checking your /usr/local/bin and /usr/local/man folders and cleaning out any old installs. RGBDS does not clean these up when running make clean. Then you can make install your 0.4.1 version of RGBDS and proceed to make and make red in the pokered-speedchoice folder. Everything should then build.

[TheR3dMage]

I tried using version 0.4.1 of rgbds like you suggested. On the Ubuntu version when I try to make red I get

rgbasm -D _RED -h -o main_red.o main.asm
warning: main.asm(14) -> home.asm(12): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(14) -> home.asm(805) -> home/audio.asm(194): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(14) -> home.asm(805) -> home/audio.asm(219): [-Wobsolete]
    `GLOBAL` is a deprecated synonym for `EXPORT`
warning: main.asm(490) -> scripts/PowerPlant.asm(10): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(717) -> scripts/CeruleanCaveB1F.asm(10): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(779) -> scripts/CeladonMart3F.asm(77): [-Wobsolete]
    Non-local labels without a colon are deprecated
rgblink -n red-speedchoice.sym -l red-speedchoice.link -m red-speedchoice.map -o red-speedchoice.gbc audio_red.o main_red.o pics_red.o text_red.o wram_red.o
error: audio_red.o is a revision 0x0008 object file; only 0x0005 is supported
make: *** [Makefile:66: red-speedchoice.gbc] Error 1

Should I be trying different versions of rgbds? did I maybe not remove the newer version correctly? Does this belong in its own bug report?

[TheR3dMage]

I have tried swapping the .dll and .exe files with the 0.4.1 ones under windows and I receive the same error message I did under Ubuntu:

$ make red

rgbasm -D _RED -h -o main_red.o main.asm
warning: main.asm(14) -> home.asm(12): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(14) -> home.asm(805) -> home/audio.asm(194): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(14) -> home.asm(805) -> home/audio.asm(219): [-Wobsolete]
    `GLOBAL` is a deprecated synonym for `EXPORT`
warning: main.asm(490) -> scripts/PowerPlant.asm(10): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(717) -> scripts/CeruleanCaveB1F.asm(10): [-Wobsolete]
    Non-local labels without a colon are deprecated
warning: main.asm(779) -> scripts/CeladonMart3F.asm(77): [-Wobsolete]
    Non-local labels without a colon are deprecated
rgblink -n red-speedchoice.sym -l red-speedchoice.link -m red-speedchoice.map -o red-speedchoice.gbc audio_red.o main_red.o pics_red.o text_red.o wram_red.o
error: audio_red.o is a revision 0x0008 object file; only 0x0005 is supported
make: *** [Makefile:66: red-speedchoice.gbc] Error 1

Now it's pretty obvious the error is caused by this audio_red.o object but I will be honest, I don't fully understand what the business about it being a 0x0008 revision actually means. Never seen an error like that before.

[TheR3dMage]

Sigh.

Ok, you can disregard the last two comments. Had forgetten to make clean the pokered-speedchoice folder and not just the rgbds folder. Once I did, those warnings remained, but the rom did compile correctly under both Ubuntu and Windows. Looks like reverting to rgbds v0.4.1 does in fact do the trick.