Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to index_points_to_lines #24

Open
dblodgett-usgs opened this issue Apr 21, 2024 · 2 comments
Open

Updates to index_points_to_lines #24

dblodgett-usgs opened this issue Apr 21, 2024 · 2 comments

Comments

@dblodgett-usgs
Copy link
Collaborator

The function needs to be broken into a few sub components and made more flexible.

  1. If the flowline match is known up front but the location along the line(s) is not known, we can pre-filter before running matcher. Could also parallelize in this case?
  2. Need to support a non-aggregated case.
  3. Generally need to refactor and simplify things. There's a lot of validation up front that is confusing things.
@dblodgett-usgs
Copy link
Collaborator Author

Should switch this over to using data.table and generally aim to reduce the memory footprint of the function.

@dblodgett-usgs
Copy link
Collaborator Author

Still need to refactor and support a non-aggregate use case. But much of this issue is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant