Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch actant role (at the background) based on entity type valency #2230

Closed
davidzbiral opened this issue May 30, 2024 · 0 comments · Fixed by #2253
Closed

Switch actant role (at the background) based on entity type valency #2230

davidzbiral opened this issue May 30, 2024 · 0 comments · Fixed by #2253
Assignees
Milestone

Comments

@davidzbiral
Copy link
Collaborator

davidzbiral commented May 30, 2024

When an Action is already filled in in a statement, assist users by selecting actant role for them based on valency frame (with notification) when they are selecting the actant through suggester or DnD-ing it from somewhere. This should work in a similar way as with the use of a proptype which is not in the user’s default language for Statements.
If the entity type of the newly added actant is not allowed by the valency frame (entity type valency) for subject, then make it a1 if allowed for a1; if not even for a1, make it a2; if for neither, make it a pseudo-actant (and display the usual warning of non-match with valency frame). Display notification about this change.

If the Action is added later, then do not apply this retroactively to the actants already added. Only perform the operation after at least one action is filled in. In case of valency frame mismatch in statements with 2+ actions, don't perform this operation and leave it as "s".

@davidzbiral davidzbiral added this to the Finetuning and bugfixing milestone May 30, 2024
@davidzbiral davidzbiral changed the title Switch actant role (at the background) based on valency frame Switch actant role (at the background) based on entity type valency May 30, 2024
@adammertel adammertel linked a pull request Jun 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants