Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use new layering/line wrapping technique #1

Open
stevedlawrence opened this issue Oct 26, 2020 · 0 comments
Open

Update to use new layering/line wrapping technique #1

stevedlawrence opened this issue Oct 26, 2020 · 0 comments
Assignees

Comments

@stevedlawrence
Copy link
Member

This schema uses things like ``dfdl:separator="%NL;%SP;" to handle line wrapping. So rather than handling line wrapping appropriately, it just treates line wrapping as a separator and icalendar values can be arrays of values rather than one long value.

This is incorrect, and actually causes failures in some cases. For example, if you wrap on on parameter key then this fails and you end up with a almost empty infoset. For example:

ATTENDEE;CN="Surname, First Name (Long stuff here)";ROLE=OPT-PARTICIPANT;R
	SVP=TRUE:mailto:[email protected]

In this case, we wrap in the middle of the RSVP key, which the schema can't handle. We only allow wrapping on values. And we can't prevent wrapping in the middle of a key.

Instead, we should use the new line wrapping technique to handle the line wrappings appropiately. We then can remove all the hacks that treat values as a sequence of NL separators.

@sramaka sramaka self-assigned this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants