Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary filtering on english voices in windows TTS? #251

Open
Applevangelist opened this issue Jan 7, 2024 · 2 comments
Open

Unnecessary filtering on english voices in windows TTS? #251

Applevangelist opened this issue Jan 7, 2024 · 2 comments
Assignees

Comments

@Applevangelist
Copy link
Contributor

In tts src win.rs it looks like you are deliberately filtering down the available voices to english. Any reason for that? Can this be removed? Thks.

@rurounijones
Copy link
Contributor

Seems like it should be a simple change but I don't know why it was done that way in the first place so I defer to @rkusa

@rkusa
Copy link
Collaborator

rkusa commented Feb 8, 2024

No particular reason other that it felt like the right thing to do to prevent accidentally using a non-English voice. But I didn't really put a lot of thought into it. Using a non-English voice to get an accent of a different language sounds like a valid use case. So I don't mind if the restriction gets removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants