Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon & Ballistics stream #210

Open
rurounijones opened this issue Jan 14, 2023 · 1 comment
Open

Weapon & Ballistics stream #210

rurounijones opened this issue Jan 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rurounijones
Copy link
Contributor

rurounijones commented Jan 14, 2023

Some users have asked us to include a way to stream weapons and ballistics.

Opening this issue for discussion. Two options I see.

  1. Add weapons to the unit stream.
  2. Have a separate weapon stream.

Advantage of having separate streams is no unecessary extra work that might not be used by clients (e.g. OverlordBot does not care about weapons).

@rurounijones rurounijones changed the title Weapon stream Weapon & Ballistics stream Jan 14, 2023
@rkusa
Copy link
Collaborator

rkusa commented Jan 16, 2023

No strong opinion from my side, just a remark: If (1), I'd say that we'd have to add a filter property to the units stream to allow filtering the kind of data that is requested. Advantage of (1) is that the weapon/ballistics updates are already ordered with the unit updates.

@rurounijones rurounijones added the enhancement New feature or request label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants