Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible block on shutdown if a connected client never reads form an opened stream #178

Open
rkusa opened this issue Sep 8, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rkusa
Copy link
Collaborator

rkusa commented Sep 8, 2022

When the gRPC server is shutdown, it closes all opened streams (events, units, ...) as follows:

  1. The stream waits for
    a) an item (event / unit update) to forward to the client
    b) a shutdown signal
  2. Whatever it receives first, is handled first
  3. If it receives an item, it is send to the client

It is possible that (1) is not run again until the client read the previous item from the stream from (3). If this theory holds true, it would be possible to block the server shutdown by establishing a connection but never reading items from it.

@rkusa rkusa self-assigned this Sep 8, 2022
@rurounijones rurounijones added the bug Something isn't working label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants