Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some API cleanup #154

Open
rurounijones opened this issue May 29, 2022 · 1 comment
Open

Some API cleanup #154

rurounijones opened this issue May 29, 2022 · 1 comment
Labels
refactoring Code improvement required

Comments

@rurounijones
Copy link
Contributor

There are two areas where we can possibly clean up APIs we are exporting.

  1. There is inconsistency in the the use of weaponName string fields and weapon tables in the lua events. We could get rid of the weaponName field and move everything into the weapon table for events that have both (hit/kill events being good examples).

  2. For the APIs that take mission filenames (LoadMission, GetMissionFileName) and which take file paths (For some reason) we could do things such as splitting the paths and filenames into two separate fields.

@rurounijones rurounijones self-assigned this May 29, 2022
@rurounijones rurounijones removed their assignment Jun 28, 2022
@rurounijones
Copy link
Contributor Author

Unassigning myself. I still hope to do it but if someone else picks it up before I can get to it then that will work.

@rurounijones rurounijones added the refactoring Code improvement required label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement required
Projects
None yet
Development

No branches or pull requests

1 participant