Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete or deprecate objects #267

Open
brandomr opened this issue Jun 26, 2023 · 2 comments
Open

Delete or deprecate objects #267

brandomr opened this issue Jun 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@brandomr
Copy link
Collaborator

Should we implement cascading deletes? This will get tricky--maybe instead we should have some kind of deprecation flag. If we were to delete a model what would we do?.....

  1. delete associated configs
  2. remove it from projects
  3. remove it from provenance (would this break chains...?)

This seems to me to be tricky but ultimately will be important to sort out.

@toddroper toddroper added the enhancement New feature or request label Jun 27, 2023
@brandomr
Copy link
Collaborator Author

@YohannParis @pascaleproulx any thoughts on what should happen when someone deletes something? Do we even care to allow deletion right now? Removing objects from the workflow doesn't actually delete them under the hood. Removing them from the project doesn't delete them under the hood either.

A potential issue would be when the user deletes a model--delete associated simulation runs, model configs, and remove them from all projects and workflows?

@YohannParis
Copy link
Member

I think we should keep the soft-delete that is in place right now.
I do believe it is a transition problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants