Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQUIT with no parameters #176

Open
rscs opened this issue Nov 6, 2020 · 1 comment · May be fixed by #205
Open

SQUIT with no parameters #176

rscs opened this issue Nov 6, 2020 · 1 comment · May be fixed by #205
Labels
bug

Comments

@rscs
Copy link
Contributor

rscs commented Nov 6, 2020

There's logic in m_squit that closes the connection if SQUIT is called with no parameters:

/* This is actually protocol error. But, well, closing the link is very proper answer to that... */

This makes sense from a server<>server context, but if an oper accidentally types /squit with no parameters, it disconnects them. We should probably reply with ERR_NEEDMOREPARAMS if it's an oper doing the SQUIT.
@rscs rscs added the bug label Nov 6, 2020
@jfcantu
Copy link
Member

jfcantu commented Nov 6, 2020

But fixing this removes the opportunity to laugh at the IRCops dumb enough to do this.

In case, uh, someone were hypothetically dumb enough to do this.

@eaescob eaescob linked a pull request Apr 6, 2022 that will close this issue
Squit Issue 176 #205
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Squit Issue 176 holbrookb/bahamut
2 participants
@rscs @jfcantu