feat: add cyclonedx.model.dependency.Dependency.provides
#735
Conversation
Signed-off-by: Uzair Chhapra <[email protected]>
uzairchhapra
force-pushed
the
feat/691-uzair-provides
branch
from
f2ad0ed to
fb4598d
Compare
Signed-off-by: Uzair Chhapra <[email protected]>
|
@jkowalleck PR is ready for review. |
jkowalleck
changed the title
cyclonedx.model.dependency.Dependency.providescyclonedx.model.dependency.Dependency.provides
|
thank you for your contribution, @uzairchhapra . the implementation looks promising. Regarding tests, we tend to go with an integration-test snapshot-solution, over detailed unit tests. |
Signed-off-by: Uzair Chhapra <[email protected]>
Signed-off-by: Uzair Chhapra <[email protected]>
Signed-off-by: Uzair Chhapra <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
| self, | ||
| target: Dependable, | ||
| depends_on: Optional[Iterable[Dependable]] = None, | ||
| provides: Optional[Iterable[Dependable]] = None, |
There was a problem hiding this comment.
instead of adding a new parameter here, how about adding a new method instead: register_provision(self, target: Dependable, provides: Optional[Iterable[Dependable]] = None).
what do you think about this?
this would fit the original architectural plans better.
| @@ -0,0 +1,113 @@ | |||
| { | |||
There was a problem hiding this comment.
How do I restrict the tests to only pickup the provides parameter in Dependency when schema is 1.6? When I re-ran the snapshots I can see 10 errors:
- 5 for schema v1.0 to v1.5 JSON
- 5 for schema v1.0 to v1.5 XML
There was a problem hiding this comment.
this could be fixed by a view filter.
here is an example:
cyclonedx-python-lib/cyclonedx/model/bom.py
Lines 193 to 200 in 5788bc1
There was a problem hiding this comment.
I tried adding it here:
The tests still seem to fail for all other SBOM specs (v1.0 to v1.5).
I am sure I must be missing something here...
There was a problem hiding this comment.
ran all tests, all passed.
see https://github.com/CycloneDX/cyclonedx-python-lib/actions/runs/11883414982/job/33123440693?pr=735
Signed-off-by: Uzair Chhapra <[email protected]>
| @@ -1310,6 +1310,28 @@ def get_bom_with_definitions_standards() -> Bom: | |||
| ) | |||
|
|
|||
|
|
|||
| def get_bom_v1_6_with_provides() -> Bom: | |||
There was a problem hiding this comment.
please rename to get_bom_with_provides.
there is no intention to have models for certain CDX versions only.
In fact, it is intended to test the serialization with a target that is expected to omit certain parts.
Fixes #691