Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should default config include test scope? #416

Open
blommish opened this issue Apr 8, 2024 · 3 comments
Open

Should default config include test scope? #416

blommish opened this issue Apr 8, 2024 · 3 comments
Labels
good first issue Good for newcomers
Milestone
2.0.0

Comments

@blommish
Copy link

blommish commented Apr 8, 2024 •
edited
Loading

  1. When generating bom with default config, the test scope is included.
    https://github.com/CycloneDX/cyclonedx-gradle-plugin/compare/master...blommish:cyclonedx-gradle-plugin:default-config-including-test-scope?expand=1

In the maven-plugin, the test scope is not included by default
https://github.com/CycloneDX/cyclonedx-maven-plugin?tab=readme-ov-file#default-values

  1. skipConfigs does not seem to make any difference.
@glefloch
Copy link
Member

I will remove it to match the maven plugin behaviour

@skhokhlov skhokhlov added the good first issue Good for newcomers label Jul 22, 2024
@blommish
Copy link
Author

Any updates on this?

@VinodAnandan
Copy link

@skhokhlov labeled it as a "good first issue". I think it means that anyone is welcome to contribute to the PR.

@blommish blommish mentioned this issue Sep 6, 2024
Open
@skhokhlov skhokhlov added this to the 2.0.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@blommish @skhokhlov @glefloch @VinodAnandan