Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-gallery): ComponentPicker with automatic folder nesting [1.5h] #20

Open
2 tasks
mesqueeb opened this issue Sep 9, 2020 · 0 comments
Open
2 tasks
Labels
enhancement New feature or request
Milestone

Comments

@mesqueeb
Copy link
Member

mesqueeb commented Sep 9, 2020

Prerequisite

#19

Goal

Currently a picker grid or list would render atoms / molecules based on this code:

const { atoms, molecules } = getComponentPaths(componentFilesList)

Instead, we want to auto-detect all folders inside a "componentFilesList" and render all components found inside any folder. Not just atoms and molecules.

In the future, if people want to only show atoms and molecules like the original implementation, they can just pass that into the "include" prop to the component-gallery:

<ComponentGallery :include="['atoms/', 'molecules/']" />

So we make a list with all folders; subfolders & components, and we somehow display it nested in both the "ComponentPickerGrid" and "ComponentPickerList"

  • implement the above

  • deprecate the formElementPrefix prop. If the dev wants something like this, he can just group his "form elements" into a sub-folder in atoms.

@mesqueeb mesqueeb changed the title feat(component-gallery): ComponentPicker with automatic folder nesting feat(component-gallery): ComponentPicker with automatic folder nesting [1.5h] Sep 9, 2020
@mesqueeb mesqueeb added this to the release milestone Oct 16, 2020
@mesqueeb mesqueeb added the enhancement New feature or request label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants