Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky / pinnable columns demo uses the column header modifier on cells -- seems off #71

Open
NullVoxPopuli opened this issue Nov 16, 2022 · 1 comment

Comments

@NullVoxPopuli
Copy link
Contributor

this is the code at the time of reporting:

 {{#each this.table.rows as |row|}}
        <tr class="relative">
          {{#each this.table.columns as |column|}}
            <td
              {{this.table.modifiers.columnHeader column}}
              class="{{if (this.isSticky column) 'bg-basement' 'bg-ground-floor'}}"
            >

using the columnHeader modifier seems wrong.
In the mean time, I can do what I need to with the isSticky helper, but should there be a cell modifier for this situation?

@NullVoxPopuli
Copy link
Contributor Author

semi resolved in #94 -- long term fix requires "cell modifiers" which, for performance, is blocked by emberjs/rfcs#883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant