Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android DefaultPushNotificationHandler "silent" flag not case sensitive #170

Open
bPoller2810 opened this issue Sep 9, 2021 · 0 comments

Comments

@bPoller2810
Copy link

bPoller2810 commented Sep 9, 2021

The DefaultPushNotificationHandler for Android in method "void OnReceived(IDictionary<string, object> parameters)" does a calue check in line 151 for the key "silent". The Values to be a valid silent Notification are "true" and "1".

in my Case the resulting Value was "True" and the Handler resulted in unexpected behaviour.

This check should be made case sensitive (either with one more check or a "ToLower()" )

To the Maintainers:

  • Is this something you would consider a improvement?
  • Would you like to implement this for yourself or do you prefer a PullRequest?

PS: i should not forget to mention: if the app is in background this "behaviour" freezes the Android app completly. (a exception only occured 1 out of ~60 tests for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant