chore: upgrade to rails 7.2, ruby {3.2, 3.3} and add test config #6
Conversation
adi-herwana-nus
force-pushed
the
adi/upgrade-rails-7-2
branch
from
a2d3509 to
d0d178a
Compare
There was a problem hiding this comment.
@adi-herwana-nus some comments
Also, make sure to bump the version by changing the versioning inside lib/active_record/acts_as/version.rb
| @@ -23,8 +24,19 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| ruby-version: ['3.0', '3.1', '3.2'] | |||
| activerecord: ['6.0', '6.1', '7.0', '7.1'] | |||
| ruby-version: ['3.0', '3.1', '3.2', '3.3'] | |||
There was a problem hiding this comment.
actually, since now we're already in Rails 7.0 and Ruby 3.1, we only need the testing for
- Rails 7.0, 7.1, 7.2
- Ruby 3.1, 3.2, 3.3
The inclusion of Rails 6.0, 6.1 and also Ruby 3.0 is okay, just that it's redundant for our codebase (this library is only for our internal usage anyway)
There was a problem hiding this comment.
Removed the rails 6 configurations, leaving behind rails 7.0, 7.1, 7.2 and Ruby 3.0, 3.1, 3.2, 3.3.
| @@ -14,6 +14,7 @@ on: | |||
| branches: ['master'] | |||
| schedule: | |||
| - cron: '0 0 * * 0' | |||
There was a problem hiding this comment.
please consider carefully if you might need to remove this cron.. If you maintain this, the testing will be run once a week and last time, the test failed unexpectedly while nothing has changed.
You might want to investigate those as well
There was a problem hiding this comment.
Added workflow_dispatch trigger to run actions manually to resolve intermittent failures.
adi-herwana-nus
force-pushed
the
adi/upgrade-rails-7-2
branch
from
d0d178a to
6787570
Compare
- migrated pipeline from 'coveralls' to 'coveralls_reborn' - update test case for ruby 3.3 - bump version and update changelog
adi-herwana-nus
force-pushed
the
adi/upgrade-rails-7-2
branch
from
6787570 to
6861603
Compare
coverallstocoveralls_reborndue to incompatibility with ruby 3.2+.RUBY_VERSIONvariable for a specific test case broken by Ruby 3.3 message formatting change.