Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop with 301 redirect #53

Open
andreialecu opened this issue Apr 7, 2021 · 2 comments
Open

Infinite loop with 301 redirect #53

andreialecu opened this issue Apr 7, 2021 · 2 comments

Comments

@andreialecu
Copy link

Noticed this while using Flipper while developing.

The countly server url we were using had a redirect. In this case it was a http to https redirection.

image

The sequence above was being logged once every few miliseconds resulting in an infinite loop. This completely kills the app's performance and I suspect results in high battery usage.

We're using 20.4.9. We'll update to the latest version and report if the problem still exists.
@andreialecu
Copy link
Author

The same problem seems to exist on 20.11.5, to some extent. I notice the same messages logged:

[Connection Processor] code:[301], response:[<html>
<head><title>301 Moved Permanently</title></head>
<body>
<center><h1>301 Moved Permanently</h1></center>
</body>
</html>], request: app_key=...&timestamp=1617785273651&hour=11&dow=3&tz=180&sdk_version=20.11.5&sdk_name=js-rnb-android...
[Connection Processor] Encountered redirect, will retry

However, it seems to no longer loop and do it 50 times per second. It seems to properly wait longer between retries.

Should redirects however be handled more cleanly?

@ArtursKadikis
Copy link
Member

Hello, thank you for reporting this. The high retry rate is a bug the we have observed and we will release a fix of this in the next release.

Currently we don't really handle redirection requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreialecu @ArtursKadikis