Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace SciPy's interp1d with new intended interpolation API #27

Closed
MetinSa opened this issue Apr 29, 2024 · 1 comment · Fixed by #29
Closed

Replace SciPy's interp1d with new intended interpolation API #27

MetinSa opened this issue Apr 29, 2024 · 1 comment · Fixed by #29
Assignees
@dncnwtts
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v1.0.0

Comments

@MetinSa
Copy link
Collaborator

MetinSa commented Apr 29, 2024

scipy.interpolate.interp1d is now considered legacy code and should be switched out with the interpolation API.
CubicSpline is probabily the way to go.
@MetinSa MetinSa added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2024
dncnwtts added a commit that referenced this issue Apr 29, 2024
@dncnwtts
Attempts to fix #27, currently fails due to keyword arguments in inte…
090b557 
…rp_kind.
@MetinSa MetinSa linked a pull request Apr 29, 2024 that will close this issue
Attempts to fix #27, currently fails due to keyword arguments in interp_kind #28
Closed
@MetinSa MetinSa mentioned this issue Apr 29, 2024
Merged
16 tasks
@MetinSa MetinSa linked a pull request Apr 29, 2024 that will close this issue
v1.0.0 #29
Merged
16 tasks
@MetinSa MetinSa added this to the v1.0.0 milestone May 1, 2024
@MetinSa
Copy link
Collaborator Author

MetinSa commented May 4, 2024

Lets begin by just doing linear interpolation and consider a cubic spline for a later release.

@MetinSa MetinSa closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dncnwtts dncnwtts

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.0.0
2 participants
@dncnwtts @MetinSa