Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use astropy SkyCoord to perform rotation between coordinate frames #20

Closed
MetinSa opened this issue Apr 19, 2024 · 1 comment · Fixed by #25 or #29
Closed

Use astropy SkyCoord to perform rotation between coordinate frames #20

MetinSa opened this issue Apr 19, 2024 · 1 comment · Fixed by #25 or #29
Assignees
@MetinSa
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@MetinSa
Copy link
Collaborator

MetinSa commented Apr 19, 2024

from pyOpenSci/software-submission#161:

Instead of using the healpy rotator.Rotator object, we should use the SkyCoord objects directly for coordinate transformation. This would use the already initialized SkyCoord objects and integrate better with Astropy.
@MetinSa MetinSa added the enhancement New feature or request label Apr 19, 2024
@MetinSa MetinSa self-assigned this Apr 19, 2024
@MetinSa MetinSa mentioned this issue Apr 27, 2024
Merged
This was linked to pull requests Apr 27, 2024
Replace healpy with astropy-healpix and add new API to directly support SkyCoord objects #25
Merged
v1.0.0 #29
Merged
@MetinSa MetinSa added this to the v1.0.0 milestone May 1, 2024
@MetinSa
Copy link
Collaborator Author

MetinSa commented May 1, 2024

This is now done internally with the SkyCoord object in v1.0.0

@MetinSa MetinSa closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MetinSa MetinSa

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
1 participant
@MetinSa