Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit isInSync meaning in SyncState #8890

Open
StefanBratanov opened this issue Dec 5, 2024 · 2 comments
Open

Revisit isInSync meaning in SyncState #8890

StefanBratanov opened this issue Dec 5, 2024 · 2 comments

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Dec 5, 2024 •
edited
Loading

In SyncState enum, we have IN_SYNC and AWAITING_EL. AWAITING_EL essentially means that the beacon chain is synced and the head is optimistic. In regards to the isInSync method, which is used in a few places, we only treat IN_SYNC as inSync. It is worth visiting the usages of this method and seeing if there are places where AWAITING_EL could still be considered in sync.
@StefanBratanov StefanBratanov mentioned this issue Dec 5, 2024
Merged
2 tasks
@lucassaldanha
Copy link
Member

Probably worth checking if we need to add a note about this behaviour on the consensus-spec or Beacon API spec.

@mehdi-aouadi
Copy link
Contributor

Some history about the is_syncing field in the GetSyncing API:
First need expressed here: ethereum/beacon-APIs#77 (comment)
Then the field was introduced in this PR: ethereum/beacon-APIs#121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mehdi-aouadi @lucassaldanha @StefanBratanov