-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No delay when fetching blobs with known block and no attempt to recover blobs for unknown block #8927
base: master
Are you sure you want to change the base?
No delay when fetching blobs with known block and no attempt to recover blobs for unknown block #8927
Conversation
e03e619
to
9126d62
Compare
be5f764
to
4d0a6c8
Compare
nice! I'll play around with this tomorrow |
13721c4
to
a09c5ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed I'd add an delay before requesting blobs via RPC when local el doesn't have the missing blob(s)
...ansition/src/main/java/tech/pegasys/teku/statetransition/blobs/BlockBlobSidecarsTracker.java
Outdated
Show resolved
Hide resolved
...ansition/src/main/java/tech/pegasys/teku/statetransition/blobs/BlockBlobSidecarsTracker.java
Outdated
Show resolved
Hide resolved
66c272a
to
9d1d5d9
Compare
...ansition/src/main/java/tech/pegasys/teku/statetransition/blobs/BlockBlobSidecarsTracker.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd suggest running a local interop or deploy it to a Holesky node and see how it goes
PR Description
Changed the flow to be as such:
Fixed Issue(s)
fixes #8796
Documentation
doc-change-required
label to this PR if updates are required.Changelog