Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate gas constants #783

Open
OlivierBBB opened this issue Jun 24, 2024 · 0 comments
Open

Remove duplicate gas constants #783

OlivierBBB opened this issue Jun 24, 2024 · 0 comments
Labels
cleaning Make the code easier to read by cleaning it

Comments

@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Jun 24, 2024 •
edited
Loading

We have two sources for gas constants

  • GasConstants.java
  • GlobalConstants.java (obtained from the Lisp)

Only one of these should be authoritative and it makes sense that it be the GlobalConstants.java derived from the Lisp.) This also entails modifying the opcodes.yml to target the correct gas constants.
@letypequividelespoubelles letypequividelespoubelles added the cleaning Make the code easier to read by cleaning it label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleaning Make the code easier to read by cleaning it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OlivierBBB @letypequividelespoubelles