Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenize isInstFam() methods #749

Open
OlivierBBB opened this issue May 31, 2024 · 0 comments
Open

Homogenize isInstFam() methods #749

OlivierBBB opened this issue May 31, 2024 · 0 comments
Assignees
@OlivierBBB
Labels
cleaning Make the code easier to read by cleaning it

Comments

@OlivierBBB
Copy link
Collaborator

We currently have several places where (for some instruction familly instFam) we implement the boolean methods

public boolean isInstFam() { ... }

For instance we have

  • isJump, isCall, isCreate in the OpCode class while
  • isPush, isHalt, isInvalid are in the OpCodeData class.
@OlivierBBB OlivierBBB self-assigned this May 31, 2024
@letypequividelespoubelles letypequividelespoubelles added the cleaning Make the code easier to read by cleaning it label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierBBB OlivierBBB

Labels
cleaning Make the code easier to read by cleaning it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OlivierBBB @letypequividelespoubelles