Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data that needs to be popped #1499

Open
OlivierBBB opened this issue Nov 14, 2024 · 1 comment
Open

Data that needs to be popped #1499

OlivierBBB opened this issue Nov 14, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Nov 14, 2024

Here are some data we follow throughout a conflation that we currently don't pop with popped transactions, but which we should just so as to be clean.

DeploymentInfo

To some extent this doesn't matter now since blocks are first sequenced (and for sequencing this popping doesn't matter) and there may always be a first round before trace production. But logically this is an oversight. And would come across as such to anyone reviewing the code. Plus this would be a place where we could add unit tests for the deployment numbers and statuses: pop a transaction that performs some deployment, redeploy in the next transaction.

@OlivierBBB OlivierBBB added the documentation Improvements or additions to documentation label Nov 14, 2024
@letypequividelespoubelles
Copy link
Collaborator

we could (should ?) pop the endBlockDefers and endConflationDefers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants