Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Tests for testMxpRandomAdvanced() #1444

Closed
DavePearce opened this issue Oct 22, 2024 · 2 comments · May be fixed by #1448
Closed

Failing Tests for testMxpRandomAdvanced() #1444

DavePearce opened this issue Oct 22, 2024 · 2 comments · May be fixed by #1448
Assignees
@lorenzogentile404 @letypequividelespoubelles
Labels
bug Something isn't working

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented Oct 22, 2024 •
edited by lorenzogentile404
Loading

The test testMxpRandomAdvanced() describes a large number of potential tests, of which one is run as determined by a fixed random seed. Since the random seed is shared between tests in the same file, it means that the order in which this test is run will determine exactly which parameters are used for it. For example, if a new test is added before testMxpRandomAdvanced then this will change the parameters used to generate its test.

It turns out, for some parameters, that testMxpRandomAdvanced fails. Some examples (with their parameters) are given below.

Example 1

  • Random Seed: 166
  • instructionCount = 2
  • INSTRUCTION_COUNT_INIT = 3

Example 2

  • Random Seed: 44
  • instructionCount = 3
  • INSTRUCTION_COUNT_INIT = 3

Example 3

  • Random Seed: 244
  • instructionCount = 5
  • INSTRUCTION_COUNT_INIT = 5
@DavePearce DavePearce added the bug Something isn't working label Oct 22, 2024
@DavePearce
Copy link
Collaborator Author

DavePearce commented Oct 22, 2024 •
edited
Loading

Example 1 (Bytecode)

0x7f597f0000000000000000000000000000000000000000000000000000000000007f0000000000000000000000000000000000000000000000000000000000000013527f00297f00000000000000000000000000000000000000000000000000000000007f0000000000000000000000000000000000000000000000000000000000000033527f0000017f000000000000000000000000000000000000000000000000000000007f0000000000000000000000000000000000000000000000000000000000000053527f0000044b397f00000000000000000000000000000000000000000000000000007f0000000000000000000000000000000000000000000000000000000000000073527f0000000000007f00000000000ead09a146e711e824104d5e8391144697f4ee427f0000000000000000000000000000000000000000000000000000000000000093527f803d53a1b0cf71fd0000000000000000000000000000000000000000000000007f00000000000000000000000000000000000000000000000000000000000000b3527f00000000000000000000000000000000000000000000000000000000000000a87f00000000000000000000000000000000000000000000000000000000000000137f000000000000000000000000000000000000000000000000000000000000042bf07f00000000000000000000000000000000000000000000000000000000000001727f00000000000000000000000000000000000000000000000000000000000005d4f3

Example 2

0x597f597f00000000000000000000000000000000000000000000000000000000331a7f000000000000000000000000000000000000000000000000000000000000000d527f8bbf7f00000000000000000000000000000000000000000000000000000000007f000000000000000000000000000000000000000000000000000000000000002d527f000053527f0000000000000000000000000000000000000000000000000000007f000000000000000000000000000000000000000000000000000000000000004d527f00000000007f00000000000000000000000003c89188939dcb717174bd0f6c787f000000000000000000000000000000000000000000000000000000000000006d527f6c59aa6c662cfd000000000000000000000000000000000000000000000000007f000000000000000000000000000000000000000000000000000000000000008d527f00000000000000000000000000000000000000000000000000000000000000877f000000000000000000000000000000000000000000000000000000000000000d7f000000000000000000000000000000000000000000000000000000000066558cf07f00000000000000000000000000000000000000000000000000000000000004bb7f0000000000000000000000000000000000000000000000000000000000000035fd

Example 3

0x7f59597f00000000000000000000000000000000000000000000000000000000007f00000000000000000000000000000000000000000000000000000000000002b3527f00298d7f000000000000000000000000000000000000000000000000000000007f00000000000000000000000000000000000000000000000000000000000002d3527f0000008f7f0000000000000000000000000000000000000000000000000000007f00000000000000000000000000000000000000000000000000000000000002f3527f000000000137597f0000000000000000000000000000000000000000000000007f0000000000000000000000000000000000000000000000000000000000000313527f00000000000000007f000000e3c89828193cffd9745d7ce0a1a182a5f1f038a17f0000000000000000000000000000000000000000000000000000000000000333527f649489326d4d36a885fd000000000000000000000000000000000000000000007f0000000000000000000000000000000000000000000000000000000000000353527f00000000000000000000000000000000000000000000000000000000000000aa7f00000000000000000000000000000000000000000000000000000000000002b37f0000000000000000000000000000000000000000000000000000000000000005f07f00000000000000000000000000000000000000000000000000000000000000167f000000000000000000000000000000000000000000000000000000000000000e7f0000000000000000000000000000000000000000000000000000000000000d48397f000000000000000000000000000000000000000000000000000000000285c31c7f00000000000000000000000000000000000000000000000000000000000002c4537f00000000000000000000000000000000000000000000000000000000000007917f00000000000000000000000000000000000000000000000000000000000000c2527f00000000000000000000000000000000000000000000000000000000000000017f0000000000000000000000000000000000000000000000000000000000000031f3

@lorenzogentile404 lorenzogentile404 linked a pull request Oct 22, 2024 that will close this issue
test(CALL): zero size, huge return at offset, huge call data offset, huge return data offset #1448
Open
@DavePearce
Copy link
Collaborator Author

See also #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzogentile404 lorenzogentile404

@letypequividelespoubelles letypequividelespoubelles

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@DavePearce @lorenzogentile404 @letypequividelespoubelles