Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Health Check Endpoints for Liveness and Readiness #263

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

alainncls
Copy link
Collaborator

@alainncls alainncls commented Dec 5, 2024

Description

This PR updates the health check endpoints to align with best practices:

  • Adds a new /live endpoint that always returns a 200.
  • Adjusts the /health endpoint to focus exclusively on readiness checks.
  • Renames the /health endpoint to /ready

Related ticket

This PR fixes #264

@alainncls alainncls self-assigned this Dec 5, 2024
@alainncls alainncls force-pushed the chore/split-healthcheck-and-readiness-endpoints branch from 62e410c to 115bd56 Compare December 6, 2024 08:45
@alainncls alainncls changed the title chore: Split healthcheck and readiness endpoints chore: Split liveness and readiness endpoints Dec 6, 2024
@alainncls alainncls force-pushed the chore/split-healthcheck-and-readiness-endpoints branch from 115bd56 to 977d358 Compare December 6, 2024 08:47
@alainncls alainncls changed the title chore: Split liveness and readiness endpoints chore: Update Health Check Endpoints for Liveness and Readiness Dec 6, 2024
@alainncls alainncls force-pushed the chore/split-healthcheck-and-readiness-endpoints branch from 977d358 to c96373f Compare December 11, 2024 09:46
@alainncls alainncls requested a review from a team as a code owner December 11, 2024 09:46
@alainncls alainncls merged commit 7a739cd into main Dec 11, 2024
2 checks passed
@alainncls alainncls deleted the chore/split-healthcheck-and-readiness-endpoints branch December 11, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Health Check Endpoints for Liveness and Readiness
3 participants