Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corset didn't pick up typo in Shakira constraints file??? #254

Open
booleanfunction opened this issue Sep 5, 2024 · 2 comments
Open

Corset didn't pick up typo in Shakira constraints file??? #254

booleanfunction opened this issue Sep 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@booleanfunction
Copy link

I noticed that Corset didn't pick up "id-data" as being a problem in the Shakira constraints file, line 69.

I think this is a typo and should be "is-data"???

https://github.com/Consensys/linea-constraints/blob/7fe32e2761e3246628fc135dd5e3837e01ba1295/shakiradata/constraints.lisp#L69

@DavePearce
Copy link
Collaborator

@booleanfunction So, the issue seems to be that is-last-data-row is not actually used anywhere. Is that right?

@DavePearce
Copy link
Collaborator

I couldn't recreate the issue when the function in question is being used. But I can recreate it when its not being used:

(module m1)
(defcolumns X Y Z)

(defun (fun1) (force-bool (+ X Y)))
(defun (fun2) (force-bool (* (fun3) (next Z))))

(defconstraint tmp () (vanishes! (fun1)))

Here, fun2 refers to the missing fun3.

@DavePearce DavePearce added the bug Something isn't working label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants