Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support custom content directory #18

Open
derekhubbard opened this issue Jul 9, 2014 · 4 comments
Open

Does not support custom content directory #18

derekhubbard opened this issue Jul 9, 2014 · 4 comments

Comments

@derekhubbard
Copy link
Contributor

I'm using WP-Skeleton (https://github.com/markjaquith/WordPress-Skeleton) in conjunction with WP-Stack (https://github.com/markjaquith/WP-Stack), both of which makes some assumptions on how you have your wordpress environment set up - one of these is the use of a custom content directory.

But, looks like the WP Ziplist plugin doesn't support custom content directories:
image

For the most part, it just looks to be some issues with stylesheets not loading successfully.

It looks like there may just be a few references to 'wp-content' to adjust in zlrecipe.php. Any chance someone would be up for modifying to support custom content dirs?
image

@dcorboy
Copy link
Contributor

dcorboy commented Jul 9, 2014

Yes, we'd be happy to consider a code change to support custom content directories. I've just pushed a couple of small changes so everything is up to date now.

Feel free to submit a pull request (or, if you are requesting that we make the changes ourselves, we can discuss that as well).

@derekhubbard
Copy link
Contributor Author

Thanks. I will submit a pull request and we can go from there. I've been
shipping code for awhile, but haven't done much with WP plugin development,
so feel free to rip it apart and fire back any suggestions. Glad to help
though. :-)

Thanks.
Derek

On Wed, Jul 9, 2014 at 12:46 PM, Dave Corboy [email protected]
wrote:

Yes, we'd be happy to consider a code change to support custom content
directories. I've just pushed a couple of small changes so everything is up
to date now.

Feel free to submit a pull request (or, if you are requesting that we make
the changes ourselves, we can discuss that as well).


Reply to this email directly or view it on GitHub
#18 (comment)
.

@dcorboy
Copy link
Contributor

dcorboy commented Jul 9, 2014

Sounds good -- I image we simply need to unify all the wp-content references to some global or #define, probably AMD_ZLRECIPE_PLUGIN_VERSION (and then fix that to use the custom content dir).

If you get stuck, just let me know and I can probably find some time to do it. Otherwise, I am happy to review your code once complete.

@dcorboy
Copy link
Contributor

dcorboy commented Jul 11, 2014

You change is merged. I then went in and cleaned up a bunch of the issues you uncovered. It's almost painfully simple now, but should be equivalent.
These changes will come out in version 2.6, but of course you are welcome to use the tip, which is in good shape. Let me know if you have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants