-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to add a potential memory leak warning to the readme #29
Comments
In order to update an existing file in S3, this module re-uploads the entire file. Due to the way S3 works, it is not practical to do anything else. For this reason you should use a relatively small maximum file size. |
Once a file rotates or reaches it's max_file_size or rotates in S3, are the logs cleared from this.buffer? Once a file rotates or reaches it's maximum do the logs on the application clear? |
Yes, buffers are cleared when a file is rotated due to reaching maximim age or size. |
Thank you! |
is there might be some potential logs losing with parallel executing? |
@vks-dbb Yes, different servers/processes should write log files to different files. The default |
S3StreamLogger will keep the logs in this.buffers until it needs to create a new file.
So if setting large rotate_every and max_file_size you can bump into a nasty memory leak.
A warning should be added to the README to warn against this, especially since the following 2 things cause you to believe it is not a possibility unless you dig into the code of the package:
The text was updated successfully, but these errors were encountered: