500 Error on template syncing

[pmwheatley]

Uncaught TypeError: basename(): Argument #1 ($path) must be of type string, PclZip given in /opt/bitnami/wordpress/wp-content/plugins/woocommerce-amazon-ebay-integration/connect.php:1195

Looking at

CodistoConnect-WooCommerce/connect.php

Lines 1185 to 1198 in 4b739d5

	$tmpfile = wp_tempnam();
	$zipfile = new PclZip( $tmpfile );
	$zipsuccess = $zipfile->create( $filestozip , PCLZIP_OPT_REMOVE_PATH, $ebayDesignDir );
	if ($zipsuccess) {
	$headers = array(
	'Cache-Control' => 'no-cache, must-revalidate',
	'Pragma' => 'no-cache',
	'Expires' => 'Thu, 01 Jan 1970 00:00:00 GMT',
	'X-Codisto-Content-Type' => 'application/zip',
	'Content-Type' => 'application/zip, application/octet-stream',
	'Content-Disposition' => 'attachment; filename=' . basename( $zipfile ),
	'Content-Length' => filesize( $tmpfile )
	);

seems there is indeed an issue here. $zipfile is an instance of PclZip not a string as required by basename.

I can see why this throws an error for us, but can't see how it doesn't throw an error for all you other customers. Seems unrelated to either PHP, Wordpress or Woocommerce version.

Fix appears to be trivial: basename( $zipfile->zipname )