Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tawk button position #815

Open
moshfeu opened this issue Jul 1, 2021 · 10 comments
Open

Improve tawk button position #815

moshfeu opened this issue Jul 1, 2021 · 10 comments
Assignees
Labels
bug Something isn't working level: player Medium level task - Usually require small code design / exploring tools skills

Comments

@moshfeu
Copy link
Member

moshfeu commented Jul 1, 2021

Tawk button is overlapping the logout button in the backoffice on mobile

Screen Shot 2021-10-14 at 17 09 10

Currently tawk's button is in the most top layer using z-index !important.
Seems like there is no way to configure this. The only way is to hide it and use tawk API to show / hide the chat.

https://help.tawk.to/article/using-a-text-link-or-button

UI-wise, we can use their image for the show / hide button so it basically will look the same.

@moshfeu moshfeu added enhancement New feature or request help wanted Extra attention is needed level: player Medium level task - Usually require small code design / exploring tools skills labels Jul 1, 2021
@OlushesiToheeb
Copy link
Contributor

HI @moshfeu I'll love to solve this issue

@moshfeu
Copy link
Member Author

moshfeu commented Oct 13, 2021

That will be great!
If you have a better idea than what I suggested above, I'd be happy to discuss.

@moshfeu moshfeu added bug Something isn't working and removed enhancement New feature or request help wanted Extra attention is needed labels Oct 13, 2021
@OlushesiToheeb
Copy link
Contributor

@moshfeu where will i find tawk button?

@moshfeu
Copy link
Member Author

moshfeu commented Oct 14, 2021

We only includes their script

function init() {
if (process.env.NODE_ENV === 'development') {
return;
}
(function() {
const s1 = document.createElement('script');
s1.async = true;
s1.src = 'https://embed.tawk.to/60a117b2185beb22b30dae86/1f5qk953t';
s1.setAttribute('crossorigin', '*');
document.head.prepend(s1);
})();
window.Tawk_API = window.Tawk_API || {};
window.Tawk_API.onLoad = function() {
window.Tawk_API.addTags(['Mentor', 'User']);
};
}

The script is creating and placing the button.

@KravMaguy
Copy link

KravMaguy commented May 21, 2022

hey I had same question as @OlushesiToheeb

wjat o i discovered was that if you comment out the return right abouve the iiffe you will see it. its inside the init funciton at the top becuase you are probably running it like me yarn dev.

@moshfeu
Copy link
Member Author

moshfeu commented May 21, 2022

Right.
Since we don't have a testing widget for now and to avoid seeing local users in production, we include the widget only on production.
@KravMaguy you are absolutely right.
@OlushesiToheeb are you still working on it or should I assign it to @KravMaguy (if he wants of course) ?

@KravMaguy
Copy link

@moshfeu yeah I will take this if @OlushesiToheeb does not reply, problem is though even if you do will still crash w/ reference error. I believe this will be fixed upon completing #899 although now you have this problem.. it needs moshe's advice how to proceed its above my current knowledge level, pretty new to typescript and zero experience w/ next.js. I think it is problem w next.js because I tested thier react component last night in normal cra project that doesnt use next and it worked as expected.

KravMaguy pushed a commit to KravMaguy/find-a-mentor that referenced this issue May 23, 2022
@KravMaguy KravMaguy mentioned this issue May 23, 2022
@KravMaguy
Copy link

Right. Since we don't have a testing widget for now and to avoid seeing local users in production, we include the widget only on production. @KravMaguy you are absolutely right. @OlushesiToheeb are you still working on it or should I assign it to @KravMaguy (if he wants of course) ?

"we don't have a testing widget for now"
you mean because no one wrote any tests for it yet?

"avoid seeing local users in production"
you mean to avoid recieving messages in tawk from people working on the project? tawk react we set those keys as env variables you wont have that problem. Maybe I dont understand. what is "local users"?

Ive solved for this issue, please accept my pull request.

@moshfeu
Copy link
Member Author

moshfeu commented May 23, 2022

"we don't have a testing widget for now"
you mean because no one wrote any tests for it yet?

I meant widget for testing locally. It's related to the second point that we don't want to receive messages from developers that working locally. Yes, if the keys would be stores in the env file it would solve the issue.

@moshfeu moshfeu assigned KravMaguy and unassigned OlushesiToheeb May 23, 2022
@KravMaguy
Copy link

ive completed this yes?
#927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working level: player Medium level task - Usually require small code design / exploring tools skills
Projects
None yet
Development

No branches or pull requests

3 participants