Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make step review acceptance criteria explicit on Google Sheets coursework #1248

Open
illicitonion opened this issue Dec 16, 2024 · 3 comments

Comments

@illicitonion
Copy link
Member

For most of our steps, the acceptance criteria are clear: For PRs they should have been reviewed and that review acted on and have the label complete, for other tasks they're explicitly listed in the ticket.

The Google Sheets exercise on https://programming.codeyourfuture.io/user-data/success/ / CodeYourFuture/Module-User-Focused-Data#104 isn't so obvious. If a new volunteer wanted to review this step, they would probably have to watch the whole video to know whether a linked to spreadsheet is done and correct.

@cjyuan / @SallyMcGrath - you've reviewed loads of these, could you suggest a few bullet points we could add to the issue or the step acceptance criteria on the dashboard so that a new step reviewer can easily verify the Google Sheets project was completed? I'm thinking things like "There is a table named WHERE clause containing 20 rows" - easy to quickly verify.

@SallyMcGrath
Copy link
Member

Note:I had planned to remove it from the new onboarding module step, so don't spend TOO long on this.

@illicitonion
Copy link
Member Author

Ooh that's a good point... We should probably re-add this exercise later on in the course (the whole "thinking about data early on" thing was one of my favourite changes we made)...

@cjyuan
Copy link
Contributor

cjyuan commented Dec 16, 2024

Google sheet should contain

  • Original two sheets of data with 100 rows per sheet
  • Separate sheets with data selected using the following queries: simple, with multiple WHERE, with ORDER BY, with GROUP BY
  • Sheet created with a query that combines data from multiple sheets

@illicitonion illicitonion moved this from 📋 Backlog to 🏗 In progress in Curriculum Planning Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants