You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For most of our steps, the acceptance criteria are clear: For PRs they should have been reviewed and that review acted on and have the label complete, for other tasks they're explicitly listed in the ticket.
@cjyuan / @SallyMcGrath - you've reviewed loads of these, could you suggest a few bullet points we could add to the issue or the step acceptance criteria on the dashboard so that a new step reviewer can easily verify the Google Sheets project was completed? I'm thinking things like "There is a table named WHERE clause containing 20 rows" - easy to quickly verify.
The text was updated successfully, but these errors were encountered:
Ooh that's a good point... We should probably re-add this exercise later on in the course (the whole "thinking about data early on" thing was one of my favourite changes we made)...
For most of our steps, the acceptance criteria are clear: For PRs they should have been reviewed and that review acted on and have the label complete, for other tasks they're explicitly listed in the ticket.
The Google Sheets exercise on https://programming.codeyourfuture.io/user-data/success/ / CodeYourFuture/Module-User-Focused-Data#104 isn't so obvious. If a new volunteer wanted to review this step, they would probably have to watch the whole video to know whether a linked to spreadsheet is done and correct.
@cjyuan / @SallyMcGrath - you've reviewed loads of these, could you suggest a few bullet points we could add to the issue or the step acceptance criteria on the dashboard so that a new step reviewer can easily verify the Google Sheets project was completed? I'm thinking things like "There is a table named WHERE clause containing 20 rows" - easy to quickly verify.
The text was updated successfully, but these errors were encountered: