Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove set loading state from some api calls #475

Open
MikeyManoguerra opened this issue Jan 5, 2021 · 0 comments
Open

remove set loading state from some api calls #475

MikeyManoguerra opened this issue Jan 5, 2021 · 0 comments

Comments

@MikeyManoguerra
Copy link
Collaborator

MikeyManoguerra commented Jan 5, 2021 •
edited
Loading

I don't think toggling between sidebar search forms doesn't need the loading screen.
opinionated issue, there's nothing wrong with it exactly, except for being a little jarring.

We also see it double load on login.
Remove the loading from login call, but can keep it on the queue call
@MikeyManoguerra MikeyManoguerra changed the title remove set loading state from getSites request remove set loading state from some api calls Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MikeyManoguerra