Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate through search results with arrow keys #91

Open
AmadeusW opened this issue Jan 20, 2015 · 4 comments
Open

Navigate through search results with arrow keys #91

AmadeusW opened this issue Jan 20, 2015 · 4 comments

Comments

@AmadeusW
Copy link
Member

When the focus is within the search box, pressing up and down keys should bring the focus down to the search results (or at least visually simulate focus). Pressing enter should navigate to the selected search result.

@JoshVarty
Copy link
Contributor

It'd be nice if this was the case for the treeview as well. So you could expand and close nodes with the arrow keys too.

Maybe there's a way we can intelligently do this for both.

@AmadeusW
Copy link
Member Author

Good idea. The search results are done using a and span elements, while the treeview operates on li tags. We could use a class attribute, or a common tag.

@JoshVarty
Copy link
Contributor

We should first do #96 and then do this one, just to make sure nothing changes and causes us to do this twice.

@AmadeusW
Copy link
Member Author

Since #96 will use icons for various file types, we could leverage the style in #71 and display icons next to search results - to help differentiate between results that are types (public, abstract, etc), methods, constructors, fields, constants etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants