Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle static constructors #64

Open
JoshVarty opened this issue Dec 28, 2014 · 1 comment
Open

Properly handle static constructors #64

JoshVarty opened this issue Dec 28, 2014 · 1 comment
Labels

Comments

@JoshVarty
Copy link
Contributor

As mentioned by @AmadeusW in #63, we need to handle static constructors properly. In C#, the fully qualified name of a static constructor is not enough to differentiate it from a parameterless constructor.

In another project, we solved this issue by adding an "isStatic" property to constructors. However, I'm not convinced that this is the best solution for Source Browser. It couples our model to the C# programming language.

Perhaps instead we can alter the fully qualified names of static constructors instead.

Namespace.Class.Constructor::static or something along those lines.

@JoshVarty JoshVarty added the bug label Dec 28, 2014
@AmadeusW
Copy link
Member

Altering the fully qualified name appears to be a good idea. After all, we're using just fully qualified name to do the mapping, and we don't use it for anything else. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants