Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SourceBrowser work with project.json repositories #117

Open
jchannon opened this issue Jan 29, 2016 · 6 comments · May be fixed by #118
Open

Make SourceBrowser work with project.json repositories #117

jchannon opened this issue Jan 29, 2016 · 6 comments · May be fixed by #118

Comments

@jchannon
Copy link

Hi,

Great tool!

I've been trying to use it with CoreFX and other repositories that don't have sln files or one's that just have project.json files. Any plans for SB to work with these types of repos?

Thanks

@JoshVarty
Copy link
Contributor

To be honest we haven't really been actively developing SB. Have you looked at Kirill Osenkov's SourceBrowser? We based ours off of his before he open sourced it. I'm not sure if it supports project.json files either though.

All that said, maybe I'll give it a shot this weekend. We originally didn't support them because there was no corresponding Roslyn workspace, but I see there's now a ProjectJsonWorkspace over at dotnet/cli.

@JoshVarty
Copy link
Contributor

@jchannon Are you familiar with how Omnisharp handles these omnisharp.json files? It looks like there are multiple project.json files for the repository. Does Omnisharp create a workspace for each one?

(You'll have to forgive me as I'm not very familiar with the new cross-plat stuff)

@JoshVarty
Copy link
Contributor

So I've started work on this and it's pretty much ready to go.

However, I've got a blocking issue with dotnet/cli. ProjectJsonWorkspace is only available for dnxcore50 right now, so I can't pull it down from NuGet.

I tried pulling down the binaries manually, but they're referencing the 1.2.0 versions of Microsoft.CodeAnalysis that aren't available from NuGet. I'm assuming they're an internal build.

To wrap up work here, I'm going to say we're going to have to wait for ProjectJsonWorkspace to become available for .NET full framework. I'm told that's the plan so I'll keep an eye out.

@JoshVarty JoshVarty linked a pull request Feb 1, 2016 that will close this issue
@jchannon
Copy link
Author

jchannon commented Feb 1, 2016

I think @Yantrio and I downloaded the project.json workspace nuget package the other day but that might have been from myget. Can you remember James?

@Yantrio
Copy link

Yantrio commented Feb 1, 2016

We used this : https://github.com/davidfowl/ProjectJsonWorkspace which is dnxcore50.
But there is another one here : https://github.com/dotnet/cli/blob/master/src/Microsoft.DotNet.ProjectModel.Workspaces/ProjectJsonWorkspace.cs which I can't find a nuget package for used by the dotnet cli.

@JoshVarty
Copy link
Contributor

The second is also dnxcore50, but my understanding is that it will be changed eventually.

It's available on the dotnet-cli MyGet: https://www.myget.org/F/dotnet-cli/api/v3/index.json as Microsoft.DotNet.ProjectModel.Workspaces. (But cannot be added until the targets are fixed).

I don't know who to bug to get it changed, but I'll keep an eye on it and when it does I'll wrap this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants