Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #316 #416

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fix #316 #416

wants to merge 18 commits into from

Conversation

namish800
Copy link

*Added CapsNet in model zoo as requested in issue #316 .
*Added support for CapsuleLayer under vision category.
*Added support for MaskCapsule layer and Length layer under Utility category.
*Added support for Squash layer under Activation category

Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove package-lock.json, Can you also add for which framework capsule net export and import works in readme.md

package.json Outdated
@@ -40,6 +40,7 @@
"eslint-plugin-jsx-a11y": "^1.4.2",
"eslint-plugin-react": "^5.2.2",
"file-loader": "^0.8.5",
"json-loader": "^0.5.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to this issue, can you remove this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ram81 I am facing a problem. on my local machine when I use Capsnet.json to import model
number of parameters are right but on Fabrik canvas number of parameters are wrong.
Can you tell me where to look to resolve this issue?

Copy link
Member

@Ram81 Ram81 Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namish800 the logic for shape calculation is ide/utils/shapes.py. For new layers that you added you can make changes to the shape calculation logic. If you have any doubts let me know.

*Added info for supported frameworks.

*Added Length layer

*Added MaskCapsule layer

*Added Capsule layer

*Added model to the modelZoo.js
@Ram81
Copy link
Member

Ram81 commented Nov 4, 2018

@namish800 Can you also share a screenshot of imported model?

@namish800
Copy link
Author

screenshot from 2018-11-04 12-51-22

@Ram81
Copy link
Member

Ram81 commented Nov 5, 2018

@namish800 can you resolve the conflicts and fix the issue with number of parameters.

@namish800
Copy link
Author

@Ram81 I added the shape calculation logic for new layers. Now input and output shapes are correct but it is not counting number of parameters of only Capsule Layer now.
I am currently trying to solve this then I will get to resolving the conflicts.

@namish800
Copy link
Author

namish800 commented Nov 5, 2018

I still can't figure out how does calculate_parameter function in ide/views.py works. Can you help me figure out how this function is calculating number of parameters.

@Ram81
Copy link
Member

Ram81 commented Nov 6, 2018

@namish800 can you test the export functionality of the model and mention it in readme also can you write import & export test for the same.

@namish800
Copy link
Author

@Ram81 I have tested the export functionality of the model and mentioned about it in the readme file.
if I am right I have to write the tests in Fabrik/tests/unit/keras_app/test_views.py ?

@Ram81
Copy link
Member

Ram81 commented Nov 7, 2018

@namish800 yes you have to write tests there until we have a separate test suite for celery tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants