Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the flags configurable using environment variables #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bzon
Copy link

@bzon bzon commented Apr 24, 2019

This PR makes the flags configurable using environment variables using the ff package:

Usage of clickhouse-exporter:
  -insecure
    	Ignore server certificate if using https. Override environment (CLICKHOUSE_INSECURE) (default true)
  -password string
    	Clickhouse password. Override environment (CLICKHOUSE_PASSWORD)
  -scrape_uri string
    	URI to clickhouse http endpoint. Override environment (CLICKHOUSE_SCRAPE_URI) (default "http://localhost:8123/")
  -telemetry.address string
    	Address on which to expose metrics. Override environment (CLICKHOUSE_TELEMETRY_ADDRESS) (default ":9116")
  -telemetry.endpoint string
    	Path under which to expose metrics. Override environment (CLICKHOUSE_TELEMETRY_ENDPOINT) (default "/metrics")
  -user string
    	Clickhouse user. Override environment (CLICKHOUSE_USER)

The reason for this is we want to make the scrape_uri configurable using environment variables.

@maxianwei
Copy link

good

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants