Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all hyphens with underscores in metrics #67

Closed
wants to merge 1 commit into from

Conversation

jpiper
Copy link

@jpiper jpiper commented Nov 9, 2021

Fixes #66

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jpiper jpiper closed this Nov 9, 2021
@jpiper jpiper deleted the patch-1 branch November 9, 2021 11:33
@jpiper
Copy link
Author

jpiper commented Nov 9, 2021

I cannot sign the CLA at this time.

alexey-milovidov added a commit that referenced this pull request Nov 9, 2021
@alexey-milovidov
Copy link
Member

Thank you! Technically there is only one possible solution for this task, so I just resubmitted it.

@alexey-milovidov
Copy link
Member

Could you please share some information - why signing the CLA is impossible?
Is it some policy from your employer? How it's motivated?

@jpiper
Copy link
Author

jpiper commented Nov 10, 2021

Yes, just that I would need to get approval from legal in order to sign this, which doesn't happen quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyphens in metric names causing scrape failures
3 participants