Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API change: Column methods should throw exceptions consistently #243

Open
Enmk opened this issue Oct 31, 2022 · 1 comment
Open

API change: Column methods should throw exceptions consistently #243

Enmk opened this issue Oct 31, 2022 · 1 comment
Assignees
Labels
3.0 Features planned for 3.0

Comments

@Enmk
Copy link
Collaborator

Enmk commented Oct 31, 2022

There are multiple places throughout the library that are really relaxed about input values\types, like:

  • overrides of Column::Append(ColumnRef column) that just do nothing if column is of not expected type
  • overrides of Column::Load that return false if column failed to load, sometimes eating an exception that could point to the root cause.
  • etc.

Fixes scheduled for next API-breaking release (3.0?):

  • Column::Append overrides should throw an exception if the input column is of the wrong type.
  • Column::Load should change return type to void and throw an exception on error.
@Enmk Enmk added the 3.0 Features planned for 3.0 label Oct 31, 2022
@Enmk Enmk changed the title API change: Column methods should throw exceptions more often API change: Column methods should throw exceptions consistently Oct 31, 2022
@1261385937
Copy link
Contributor

Just like lib boost, error_code and exceptions are both supported if API-breaking is sure

@Enmk Enmk self-assigned this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Features planned for 3.0
Projects
None yet
Development

No branches or pull requests

2 participants