Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGIN_URL is not automatically ignored #101

Open
tilsche opened this issue Dec 26, 2022 · 2 comments
Open

LOGIN_URL is not automatically ignored #101

tilsche opened this issue Dec 26, 2022 · 2 comments

Comments

@tilsche
Copy link

tilsche commented Dec 26, 2022

As per the README

Add LOGIN_REQUIRED_IGNORE_PATHS setting. Any requests which match these paths will be ignored. This setting should be a list filled with regex paths (settings.LOGIN_URL always included).

However, that does not work for me and it seems it was explicitly removed in 9ff73b4.

@CleitonDeLima
Copy link
Owner

Hi @tilsche

Actually I ended up removing it for considering the LoginView view with the login_required attribute in apps.js. But if you have a custom login view it wouldn't work anyway. Can you do a PR of that?

@tilsche
Copy link
Author

tilsche commented Dec 26, 2022

Oh, I understand now.

If I add the app, it works without setting the LOGIN_REQUIRED_IGNORE_PATHS manually. It just didn't occur to me to add an app since it is not yet mentioned in the README ;-).

I think this is primarily a question of documentation. I can try to take a shot at improving the README tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants