Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowfat missing attributes (glosses, etc) on compounds. #54

Open
klosoter opened this issue Jun 17, 2022 · 0 comments
Open

Lowfat missing attributes (glosses, etc) on compounds. #54

klosoter opened this issue Jun 17, 2022 · 0 comments

Comments

@klosoter
Copy link
Contributor

Some attributes like SDBH the Cherith glosses are on the c elements instead of the m. They thus get skipped when building the lowfat.

Trees:

<Node Cat="noun" morphId="010040220061" Unicode="תּ֣וּבַל קַ֔יִן" nodeId="0100402200610010" StrongNumberX="8423">
  <c english="Tubal-cain" mandarin="土八该隐" SDBH="תּוּבַל קַיִן:003001007:Names of People:Tubal-Cain">
    <m word="GEN 4:22!6" xml:id="o010040220061" lang="H" after=" " lemma="8423+" morph="Np" pos="noun" type="proper">תּ֣וּבַל</m>
    <m word="GEN 4:22!7" xml:id="o010040220071" lang="H" after=" " lemma="8423" morph="Np" pos="noun" type="proper">קַ֔יִן</m>
  </c>
</Node>

Lowfat

<wg class="compound">
  <w ref="GEN 4:22!6" role="noun" xml:id="o010040220061" StrongNumberX="8423" Cat="noun" Unicode="תּ֣וּבַל קַ֔יִן" morph="Np" lang="H" lemma="8423+" pos="noun" after=" ">תּ֣וּבַל</w>
  <w ref="GEN 4:22!7" role="noun" xml:id="o010040220071" StrongNumberX="8423" Cat="noun" Unicode="תּ֣וּבַל קַ֔יִן" morph="Np" lang="H" lemma="8423" pos="noun" after=" ">קַ֔יִן</w>
</wg>

I think if we want to keep them, it makes sense to put them on wg/w like this:

<wg class="compound" english="Tubal-cain" mandarin="土八该隐" SDBH="תּוּבַל קַיִן:003001007:Names of People:Tubal-Cain">
  <w ref="GEN 4:22!6" role="noun" xml:id="o010040220061" StrongNumberX="8423" Cat="noun" Unicode="תּ֣וּבַל קַ֔יִן" morph="Np" lang="H" lemma="8423+" pos="noun" after=" ">תּ֣וּבַל</w>
  <w ref="GEN 4:22!7" role="noun" xml:id="o010040220071" StrongNumberX="8423" Cat="noun" Unicode="תּ֣וּבַל קַ֔יִן" morph="Np" lang="H" lemma="8423" pos="noun" after=" ">קַ֔יִן</w>
</wg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant